DAOS-18795 control: Fix TestSystem_Database_LeadershipCallbacks#17981
Open
DAOS-18795 control: Fix TestSystem_Database_LeadershipCallbacks#17981
Conversation
|
Ticket title is 'TestSystem_Database_LeadershipCallbacks go unit test hang' |
Fix a go unit test bug that caused occasional test hangs. Also fixes a couple of subtle unprotected access bugs that were found while investigating. Features: control Signed-off-by: Michael MacDonald <github@macdonald.cx>
kjacque
reviewed
Apr 14, 2026
| // Return copies of the registered callbacks under a lock, so that they | ||
| // can be safely retrieved and executed without holding the lock. | ||
| func (db *Database) onLeadershipGainedCbs() []onLeadershipGainedFn { | ||
| db.cbMutex.Lock() |
Contributor
There was a problem hiding this comment.
Any reason these couldn't be readlocks? Since these cb functions are just reading back the contents of the arrays. Could prevent unnecessary blocking as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a go unit test bug that caused occasional test hangs. Also
fixes a couple of subtle unprotected access bugs that were found
while investigating.
Features: control
Signed-off-by: Michael MacDonald github@macdonald.cx