Open
Conversation
Contributor
|
@mcruzdev I am wondering why we need to increase to such a high number. Also could you please sign your commit |
Contributor
|
@mcruzdev I still see issues like these: |
Contributor
|
+1 I think this needs a bit more investigation here beyond upping the time since it still fails. Appreciate the efforts here 🎉 |
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1605 +/- ##
============================================
+ Coverage 76.91% 78.90% +1.98%
- Complexity 1592 2074 +482
============================================
Files 145 227 +82
Lines 4843 6256 +1413
Branches 562 684 +122
============================================
+ Hits 3725 4936 +1211
- Misses 821 972 +151
- Partials 297 348 +51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1603
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: