Skip to content

Allow shortcut setting in duplicate and snapshots#20169

Merged
TurboGit merged 1 commit intodarktable-org:masterfrom
Phemisters:enable_shortcuts_in_duplicate_and_snapshots
Feb 7, 2026
Merged

Allow shortcut setting in duplicate and snapshots#20169
TurboGit merged 1 commit intodarktable-org:masterfrom
Phemisters:enable_shortcuts_in_duplicate_and_snapshots

Conversation

@Phemisters
Copy link
Copy Markdown
Contributor

There were a few buttons which could not have shortcuts set, and this PR attempts to fix that.

This follows a pixls.us discussion, where a solution for the side-by-side button in snapshots.c was suggested.

I don't see anyone else attempting this, so I've tried the suggestion (which works for me) and created this PR.

While working on it, I noticed two buttons in the darkroom duplicate manager module also appeared to have no shortcut setting ability. This appears to be a different type of button set-up, so I have attempted to copy what I see in other places (using self instead of NULL). This seems to work when I tested it, but may be the wrong approach. I can easily remove the duplicate.c change.

* there were a few buttons which could not have shortcuts set
@dterrahe dterrahe self-requested a review January 17, 2026 15:48
Copy link
Copy Markdown
Contributor

@dterrahe dterrahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both changes looking good. Thanks for fixing the oversight!

@TurboGit TurboGit added this to the 5.6 milestone Jan 17, 2026
@TurboGit TurboGit added bugfix pull request fixing a bug priority: low core features work as expected, only secondary/optional features don't release notes: pending labels Jan 17, 2026
@TurboGit
Copy link
Copy Markdown
Member

We have a new string here, so targeting 5.6.

@Phemisters
Copy link
Copy Markdown
Contributor Author

I see this has the release notes: pending label. Since another PR (#20235) also enables shortcuts I think they could be covered by the same release notes entry, assuming both PRs get merged. I'm not sure how release notes are handled, but I think something like this might be enough:

Enabled shortcuts for some existing buttons in duplicate manager, snapshots, and AgX modules.

Copy link
Copy Markdown
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit 376403e into darktable-org:master Feb 7, 2026
5 checks passed
@Phemisters Phemisters deleted the enable_shortcuts_in_duplicate_and_snapshots branch February 7, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix pull request fixing a bug priority: low core features work as expected, only secondary/optional features don't release notes: pending

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants