Solo skipped tests shouldn't be reported by failures-only or compact reporters#2546
Solo skipped tests shouldn't be reported by failures-only or compact reporters#2546FMorschel wants to merge 2 commits intodart-lang:masterfrom
Conversation
|
I don't think I agree with treating solo differently than other skipped tests. I think I can get on board with suppressing all skips in the compact and failures only reporters. |
|
I'll start a conversation with a few folks to make a decision on what behavior we want to switch to and revisit this. |
Well, I guess it makes no difference too. Now that you said it, I realized that skipped tests wouldn't have any message to send so this would work fine too. I'll wait for your answer (after the discussions), to continue working on this. Thank you for taking a look at it already! |
|
I've updated this to remove the Small note: in the related issue, I mentioned this idea came from @jakemac53 at dart-lang/tools#2107 (comment) to help out in debugging analyzer (and related) tests. |
|
Do note that by removing that |
Closes #2546, Fixes #2542 Skipped tests with messages can cause noisy output in otherwise very short test run logs. In most cases the skip messages are not useful, so suppress them by default. They can still be seen in the expanded reporter. Expand the final output when there are skipped tests since the otherwise obvious yellow lines are no longer shown. Add support for testing against disallowed output in the compact reporter tests. Existing tests ignore unexpected output that comes between any expected lines.
|
Friendly ping @natebosch 😄 I noticed you opened a PR. Do you have any more information about your decision? |
yeah sorry for the slow response. I went ahead with my own PR to move quickly on the remaining test changes and to tweak the final output. I expect to have that one landed soon. Thanks for the PR and for the patience 😄 |
Closes #2546, Fixes #2542 Skipped tests with messages can cause noisy output in otherwise very short test run logs. In most cases the skip messages are not useful, so suppress them by default. They can still be seen in the expanded reporter. Expand the final output when there are skipped tests since the otherwise obvious yellow lines are no longer shown. Add support for testing against disallowed output in the compact reporter tests. Existing tests ignore unexpected output that comes between any expected lines.
2 participants
The issue I'm trying to fix is #2542.
I've used the
skipinformation to skip allMessages writes when inside the relevant reporters.I've already copied and added some tests here.
I'd like some guidance on whether what I did was the correct implementation (first contribution here). And once I've resolved all requests from the team, I'll add the new entry to the changelog and bump the version as needed.
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.