[ DWDS ] Reestablish WS connections with app and Chrome debugger #2728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the computer enters sleep mode, Chrome does not attempt to reestablish websocket connections when the computer wakes up. This would break debugging of web applications when DWDS is configured to communicate with the Chrome debugger or the debugged application is using web sockets to communicate with DWDS. This change adds some retry logic to reestablish these web socket connections from the injected client and to the Chrome debugger. Related to flutter/flutter#179886
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the computer enters sleep mode, Chrome does not attempt to reestablish websocket connections when the computer wakes up. This would break debugging of web applications when DWDS is configured to communicate with the Chrome debugger or the debugged application is using web sockets to communicate with DWDS.
This change adds some retry logic to reestablish these web socket connections from the injected client and to the Chrome debugger.
Related to flutter/flutter#179886