Skip to content

Conversation

@jyameo
Copy link
Contributor

@jyameo jyameo commented Dec 22, 2025

This PR removes the package:built_value dependency from HotRestartResponse and replaces it with standard Dart JSON serialization.

Changes

  • Rewrote HotReloadResponse as a simple Dart class with manual JSON serialization
  • Removed HotRestartResponse from the @SerializersFor annotation in serializers.dart
  • Updated client.dart to serialize HotRestartResponse using the wire format ['HotRestartResponse', response.toJson()]
  • Added _deserializeMessage() helper in dev_handler.dart to deserialize both built_value and non-built_value response types
  • Updated _sendHotRestartResponse in client.dart to use named parameters instead of builder pattern

Testing

  • Existing tests for hot restart functionality continue to pass with the updated implementation.
  • The change follows the same pattern used for HotReloadRequest, HotReloadResponse, and HotRestartRequest

Fixes dart-lang/sdk#62291

@jyameo jyameo requested review from biggs0125 and srujzs December 22, 2025 22:09
@jyameo jyameo merged commit 39d5eb1 into dart-lang:main Dec 22, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove built_value dependency from HotRestartResponse

2 participants