chore: removed unused struct DashSpvClientInterface

[ZocoLini]

Summary by CodeRabbit

• Chores
  • Simplified the public command interface by consolidating command dispatch functionality into a single unified method.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

This change simplifies the public API by removing the DashSpvClientInterface wrapper struct and its methods. The DashSpvClientCommand::send method now serves as the primary interface for dispatching commands, eliminating the higher-level abstraction layer that previously provided a get_quorum_by_height helper.

Changes

Cohort / File(s)	Summary
Interface Simplification dash-spv/src/client/interface.rs	Removes DashSpvClientInterface struct, its constructor, and get_quorum_by_height method; clients now use DashSpvClientCommand::send directly instead of the wrapper.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A rabbit hops through the burrow clean,
Tossing out what's not needed in between,
Simple paths are better to explore,
Less wrapping makes the way much more! 🐰✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removal of the unused DashSpvClientInterface struct and its associated code.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a01febe and 835ac18.

📒 Files selected for processing (1)

• dash-spv/src/client/interface.rs

💤 Files with no reviewable changes (1)

• dash-spv/src/client/interface.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)

• GitHub Check: macOS / core
• GitHub Check: macOS / tools
• GitHub Check: Windows / tools
• GitHub Check: fuzz (hashes_sha1)
• GitHub Check: fuzz (dash_deserialize_witness)
• GitHub Check: fuzz (dash_deserialize_script)
• GitHub Check: fuzz (dash_deserialize_address)
• GitHub Check: fuzz (hashes_sha256)
• GitHub Check: fuzz (hashes_sha512_256)
• GitHub Check: fuzz (hashes_cbor)
• GitHub Check: fuzz (dash_deserialize_block)
• GitHub Check: fuzz (hashes_ripemd160)
• GitHub Check: fuzz (hashes_json)
• GitHub Check: fuzz (dash_deserialize_amount)
• GitHub Check: Pre-commit (ubuntu-latest)
• GitHub Check: Thread Sanitizer
• GitHub Check: Pre-commit (windows-latest)
• GitHub Check: Pre-commit (macos-latest)
• GitHub Check: Address Sanitizer

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[xdustinface]

This is used by DashEvoTool to get quorum public keys. Thats what i implemented it for at least, @pauldelucia i assume you still use this?

[pauldelucia]

Yes, still using to get the quorum public keys