Skip to content

fix(dash-spv): wire up masternode persistence and shrink it 67x - #993

Open
ZocoLini wants to merge 4 commits into
devfrom
feat/masternode-diff-storage
Open

fix(dash-spv): wire up masternode persistence and shrink it 67x#993
ZocoLini wants to merge 4 commits into
devfrom
feat/masternode-diff-storage

fix(dash-spv): coderabbit comments addressed

d6083c6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 9, 2026 in 0s

77.15% (-0.03%) compared to 7e315af

View this Pull Request on Codecov

77.15% (-0.03%) compared to 7e315af

Details

Codecov Report

❌ Patch coverage is 93.49442% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.15%. Comparing base (7e315af) to head (d6083c6).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
dash/src/sml/masternode_list_engine/mod.rs 6.66% 14 Missing ⚠️
dash-spv/src/storage/mod.rs 72.72% 6 Missing ⚠️
dash-spv/src/sync/chainlock/manager.rs 91.52% 5 Missing ⚠️
dash-spv/src/client/lifecycle.rs 66.66% 3 Missing ⚠️
dash-spv/src/sync/masternodes/manager.rs 90.00% 3 Missing ⚠️
dash-spv/src/storage/masternode.rs 99.36% 2 Missing ⚠️
...ernode_list_engine/message_request_verification.rs 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #993      +/-   ##
==========================================
- Coverage   77.18%   77.15%   -0.03%     
==========================================
  Files         329      329              
  Lines       83603    83960     +357     
==========================================
+ Hits        64528    64781     +253     
- Misses      19075    19179     +104     
Files with missing lines Coverage Δ
dash-spv/src/sync/masternodes/sync_manager.rs 89.65% <100.00%> (+1.14%) ⬆️
dash/src/ephemerealdata/chain_lock.rs 97.67% <100.00%> (+0.17%) ⬆️
dash/src/sml/llmq_type/mod.rs 82.95% <ø> (ø)
dash/src/sml/masternode_list_engine/helpers.rs 100.00% <100.00%> (ø)
...ode_list_engine/non_rotated_quorum_construction.rs 86.84% <100.00%> (-0.66%) ⬇️
dash-spv/src/storage/masternode.rs 99.37% <99.36%> (+79.37%) ⬆️
...ernode_list_engine/message_request_verification.rs 84.83% <77.77%> (+0.49%) ⬆️
dash-spv/src/client/lifecycle.rs 91.04% <66.66%> (-1.27%) ⬇️
dash-spv/src/sync/masternodes/manager.rs 94.49% <90.00%> (-0.26%) ⬇️
dash-spv/src/sync/chainlock/manager.rs 92.95% <91.52%> (-0.54%) ⬇️
... and 2 more

... and 19 files with indirect coverage changes