Conversation
9b98cc1 to
b8cc51d
Compare
jorenham
left a comment
There was a problem hiding this comment.
sorry if this is premature, but maybe these comments can help 🤷🏻
| @@ -1,11 +1,52 @@ | |||
| from typing import Any | |||
| # mypy: disable-error-code="no-redef" | |||
There was a problem hiding this comment.
is this needed for the redefinition of _?
There was a problem hiding this comment.
I didn't want to name all the variables.
There was a problem hiding this comment.
There are only two hard things in Computer Science: cache invalidation and naming things.
-- Phil Karlton
There was a problem hiding this comment.
Or even better:
There are 2 hard problems in computer science: cache invalidation, naming things, and off-by-1 errors.
f203d12 to
5ad0d5c
Compare
3434139 to
0e79721
Compare
|
numpy 2.0's array_api stuff is infinitely better than 1.0's. It's a real struggle to write tests that both pass and test what we want. 😮💨 |
|
@jorenham. Ok. this PR was much easier than #32 and hopefully will help with that one, particularly in writing more comprehensive tests. Might go one |
|
Pushed to add docs to HasArrayNamespace |
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
|
Forgot to have Array inherit from HasArrayNamespace. That's kind of the most important one 😆 |
|
Ok. @jorenham now it should really be ready for a review. |
Maybe we could use array-api-compat for numpy<2.0? |
|
That's a good idea. After this PR because things are passing? |
Yea, I'll get on that soon (after I fix optype and scipy-stubs apparently being broken on |
Relies on #47A new PR to precede #32.