Skip to content

Conversation

@calvarjorge
Copy link
Contributor

@calvarjorge calvarjorge commented Jan 27, 2026

  • Rename dev-playground package name in package.json to dev-playground from appkit. This is what multiple scripts in the root package.json expect.
  • Change pnpm build:sdk (which doesn't exist) to pnpm build in the start script.

@calvarjorge calvarjorge force-pushed the jorge.calvar/fix_pnpm_start branch from d16f935 to 36cfb13 Compare January 27, 2026 13:33
@calvarjorge calvarjorge force-pushed the jorge.calvar/fix_pnpm_start branch from 36cfb13 to a2ea67f Compare January 27, 2026 13:49
@calvarjorge calvarjorge requested a review from pkosiec January 27, 2026 16:23
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small comment 👍 Before the merge, please update the last occurrences pointed in the comment. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update package-lock.json as well?
image

And .env.dist file too
image

@pkosiec
Copy link
Member

pkosiec commented Jan 27, 2026

Please also rename the PR to have chore: to avoid automatic patch release as we change just our internal development stuff 👍

@calvarjorge calvarjorge changed the title fix: rename dev-playground package name chore: rename dev-playground package name Jan 27, 2026
@calvarjorge calvarjorge merged commit 5acd841 into main Jan 27, 2026
4 checks passed
@calvarjorge calvarjorge deleted the jorge.calvar/fix_pnpm_start branch January 27, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants