pipelines: use lakeflow-pipelines template #4237
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanterov
requested review from
andrewnester,
anton-107,
denik,
jefferycheng1,
lennartkats-db,
pietern and
shreyas-goenka
as code owners
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
force-pushed
the
pipelines-cli-template
branch
from
1f111da to
6c12108
Compare
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: e5eb898
28 interesting tests: 19 RECOVERED, 6 KNOWN, 2 flaky, 1 SKIP
Top 23 slowest tests (at least 2 minutes):
|
kanterov
force-pushed
the
pipelines-cli-template
branch
from
6c12108 to
5e598b8
Compare
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Change template in "pipelines init" from "cli-pipelines" to "lakeflow-pipelines".
Remove the code for "cli-pipelines" template and point "cli-pipelines" template into "lakeflow-pipelines" in case anything relies on undocumented hidden template.
There are a few minor problems with lakeflow-pipelines template that we will address in a follow-up. For example, we create job parameters, but never use them.
Why
lakeflow-pipelines template follows recommended layout for SDP projects in DABs and is consistent with how other templates are structured.
Tests
Updated acceptance tests