-
Notifications
You must be signed in to change notification settings - Fork 134
feat: Appkit cli commands #4247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
04f4c88 to
6e23dec
Compare
|
Commit: 5d7962f
21 interesting tests: 7 KNOWN, 5 SKIP, 5 FAIL, 4 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
experimental/apps-mcp/templates/appkit/generic/client/index.html
Outdated
Show resolved
Hide resolved
experimental/apps-mcp/templates/appkit/generic/databricks.yml.tmpl
Outdated
Show resolved
Hide resolved
experimental/dev/cmd/app/prompt.go
Outdated
| @@ -0,0 +1,419 @@ | |||
| package app | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check with @pietern. He wants to unify CLI UX.
d552cd0 to
f0b22d5
Compare
9cbff3d to
38cc5a4
Compare
748d4c1 to
bc617fb
Compare
bc617fb to
26f3f28
Compare
26f3f28 to
037121a
Compare
037121a to
9ca1219
Compare
go.mod
Outdated
| github.com/BurntSushi/toml v1.6.0 // MIT | ||
| github.com/Masterminds/semver/v3 v3.4.0 // MIT | ||
| github.com/charmbracelet/bubbles v0.21.0 // MIT | ||
| github.com/briandowns/spinner v1.23.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was removed in f3a45c0.
Can you use either cmdio.NewSpinner() or the bubbles spinner?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still around.
| // ParseGitHubURL extracts the repository URL, subdirectory, and branch from a GitHub URL. | ||
| // Input: https://github.com/user/repo/tree/main/templates/starter | ||
| // Output: repoURL="https://github.com/user/repo", subdir="templates/starter", branch="main" | ||
| func ParseGitHubURL(url string) (repoURL, subdir, branch string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @shreyas-goenka
Not sure if we can/should use this for bundle init calls.
chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: validate command chore: fixup chore: remove import command chore: fixup
1f9b1ec to
47f3169
Compare
unifying through these commands
Changes
Overview
This PR adds new AppKit development commands to
databricks apps, making them first-class citizens alongside the auto-generated Apps API commands. The implementation follows the same pattern established by thepipelinescommands.New Command Structure
databricks appsnow has three command groups:deploy,dev-remote,init,logs,run-local,validatecreate,delete,get,list,start,stop, etc.get-permissions,set-permissions, etc.Key Features
databricks apps init- Initialize new AppKit projects from templates with interactive prompts, but also allowing full prompt override via flags.databricks apps dev-remote- Run local Vite dev server with WebSocket bridge to remote app (this command already exists, but now has some improvements like deriving the project from the folder and reconnecting).databricks apps validate- Run validation of the app running type checking, linting and building.databricks apps deploy- Dual-mode deployment:Directory Structure
Why
Tests