bundle/direct: add a feature-flag list to the direct deployment state#5660
Open
shreyas-goenka wants to merge 1 commit into
Open
bundle/direct: add a feature-flag list to the direct deployment state#5660shreyas-goenka wants to merge 1 commit into
shreyas-goenka wants to merge 1 commit into
Conversation
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
Integration test reportCommit: 329e0fc
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 10 slowest tests (at least 2 minutes):
|
shreyas-goenka
force-pushed
the
shreyas-goenka/direct-state-feature-flags
branch
2 times, most recently
from
663ad08 to
a1b0613
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
commented
Jun 29, 2026
| for name := range db.Features { | ||
| names = append(names, name) | ||
| } | ||
| slices.Sort(names) |
Contributor
Author
There was a problem hiding this comment.
makes tests with multiple features deterministic.
shreyas-goenka
force-pushed
the
shreyas-goenka/direct-state-feature-flags
branch
from
a1b0613 to
a550105
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
Approval status: pending
|
shreyas-goenka
commented
Jun 29, 2026
| // RecordFeature marks the state as depending on the named feature, stamping the | ||
| // minimum CLI version required to read it (from featureMinCLIVersion). It must be | ||
| // called before the WAL is started (UpgradeToWrite) so the change is persisted. | ||
| func (db *DeploymentState) RecordFeature(name string) { |
Contributor
Author
There was a problem hiding this comment.
Get rid of this function - make this decision at open.
shreyas-goenka
commented
Jun 29, 2026
| { | ||
| "state_version": 3, | ||
| "features": { | ||
| "dummy": "1.2.0" |
Contributor
Author
There was a problem hiding this comment.
talk to Julia, if aligned get rid of versions from state and consider hosting every feature on our docs page.
shreyas-goenka
force-pushed
the
shreyas-goenka/direct-state-feature-flags
branch
from
a550105 to
2d62964
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
force-pushed
the
shreyas-goenka/direct-state-feature-flags
branch
from
2d62964 to
e559fca
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
force-pushed
the
shreyas-goenka/direct-state-feature-flags
branch
from
e559fca to
c62c873
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
force-pushed
the
shreyas-goenka/direct-state-feature-flags
branch
from
c62c873 to
1a7c392
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
force-pushed
the
shreyas-goenka/direct-state-feature-flags
branch
from
1a7c392 to
d6fdd85
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Bumps the direct state schema to version 3, adding a per-state feature list (Header.Features) that maps each feature flag to the minimum CLI version required to read a state recording it. On load the CLI rejects any state recording a feature it does not know, pointing the user at the recorded version, so older CLIs fail with an actionable message instead of silently mishandling the state. Feature flags are defined in a static registry (featureMinCLIVersion) and written into the state via RecordFeature. A dummy feature is included to exercise the mechanism in tests; no real deployment records one yet. Co-authored-by: Isaac
shreyas-goenka
force-pushed
the
shreyas-goenka/direct-state-feature-flags
branch
from
d6fdd85 to
329e0fc
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds boolean feature flags to direct state. Every new feature that needs is not backwards compatible should add a feature flag rather than upgrading state version, if the state structure does not change.
We can consider adding a "per-feature" version but omitting this for now.