acc: nostamp in Python, and drop it where the stamp cannot appear - #6461
Draft
shreyas-goenka wants to merge 1 commit into
Draft
acc: nostamp in Python, and drop it where the stamp cannot appear#6461shreyas-goenka wants to merge 1 commit into
shreyas-goenka wants to merge 1 commit into
Conversation
The jq program was dense enough that a shape change would fail quietly, and an unexpected argument went straight to jq. Python states the three shapes it strips and rejects arguments outright, which it can now do because the only call site that passed any was permission_level_migration - and that test pins EnvMatrix.DMS = [""], so no stamp ever reaches it. Output is unchanged: the bundle suite passes without regenerating a golden. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses two review comments from #6444.
nostampwas a dense jq program that would fail quietly if the shape changed, and passed unexpected arguments straight to jq; it is now Python that names the three shapes it strips and rejects arguments. It can reject them because the only call site passing any waspermission_level_migration, which pinsEnvMatrix.DMS = [""]— no stamp can reach it, so the pipe is gone.Output is unchanged: the bundle suite passes with no golden regenerated.
This pull request and its description were written by Isaac.