Add direct-mode bundle support for AI Gateway model_service - #6525
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: 3016db1
Top 14 slowest tests (at least 2 minutes):
|
alex-khakhlyuk
force-pushed
the
aigov-dabs-model-service
branch
5 times, most recently
from
September 10, 2026 11:05
d4a0614 to
da2de5c
Compare
denik
reviewed
Sep 10, 2026
janniklasrose
left a comment
janniklasrose
left a comment
Member
There was a problem hiding this comment.
please add a .nextchanges fragment for this resource
alex-khakhlyuk
force-pushed
the
aigov-dabs-model-service
branch
4 times, most recently
from
September 10, 2026 16:57
fbebe8c to
952d69a
Compare
alex-khakhlyuk
force-pushed
the
aigov-dabs-model-service
branch
from
September 11, 2026 07:51
952d69a to
dcc3c4e
Compare
Adds direct-engine Databricks Asset Bundle support for the Unity Catalog AI Gateway model service securable (model_services), so it can be declared and deployed from databricks.yml. First of a stacked split of #6410 (mcp_services and model_provider_services follow). Direct engine only. - bundle/config/resources/model_service.go: flat ConfigResource exposing the immutable parent + model_service_id identity plus the mutable comment/config body. - bundle/direct/dresources/model_service.go: CRUD onto the AiGateway service; DoRead reconstructs identity from the server-derived name so it participates in drift detection. - resources.yml: parent + model_service_id as immutable id fields; the server-computed output-only config fields (inference_table.table/is_deleted and routing.destinations[*]/fallback.destinations[*].is_deleted) suppressed to avoid phantom drift. - Registration, testserver implementation, regenerated schema, acceptance (basic + remote-delete + bind), and an invariant config. - Wired model_services into the direct-only Terraform-lifecycle ignore list and the statemgmt full-resource-coverage test suite, and fully populated the SDK struct literals so the dresources exhaustruct lint passes. Scope is strictly model_service: no changes to jobs suppression or other resources. Owner is deferred (the API returns effective_owner); permissions use grants; no Catalog Explorer URL is wired up yet. Co-authored-by: Isaac <no-reply@databricks.com>
alex-khakhlyuk
force-pushed
the
aigov-dabs-model-service
branch
from
September 11, 2026 11:37
dcc3c4e to
3016db1
Compare
janniklasrose
approved these changes
Sep 11, 2026
janniklasrose
left a comment
janniklasrose
left a comment
Member
There was a problem hiding this comment.
looking forward to the other AIG resources 
janniklasrose
enabled auto-merge
September 11, 2026 12:41
pranshupand-db
pushed a commit
to pranshupand-db/cli
that referenced
this pull request
Sep 11, 2026
…tabricks#6618) ## What Allow `get_field_behaviors` to exhaustively extract from specs. This discovers `OUTPUT_ONLY` / `INPUT_ONLY` field behaviours. ## Why Follow-up to the discussion on databricks#6525 (databricks#6525 (comment)): the `model_services` resource can't rely on the generator to suppress its output-only config fields, because the destination-config type reused under `config.routing.fallback.destinations[*]` is deduped away. That is a general generator bug, not model_services-specific — it already drops correct suppressions on the three resources above. Fixing it here lets a later `apitypes.yml` pin (`model_services: catalog.ModelService`, riding with databricks#6525) generate the full set instead of hand-classifying it. ## Explanation (There's also inline comments on `resources.generated.yml`) `get_field_behaviors` in `bundle/direct/tools/generate_resources.py` threaded a single global `visited` set through the whole schema walk, deduping by type name across the entire tree. A type reached at two sibling paths was therefore expanded only at the first one, and its nested `OUTPUT_ONLY` / `INPUT_ONLY` annotations were dropped at every later path — surfacing later as phantom drift on those server-populated fields. This scopes `visited` to the current root→node path (each branch gets its own copy via `visited | {ref}`) so a self-referential type still terminates the recursion, but a type reused at sibling paths is expanded at each occurrence. `max_depth` stays as the runaway guard. ## Tests - `go test ./bundle/direct/dresources/` passes, including `TestResourcesYMLNoRedundantRules` (the recovered entries don't collide with hand-written `resources.yml` rules). - Regeneration is idempotent; the script is ruff-clean and formatted with the pinned `ruff@0.15.17`. - No acceptance test references the recovered fields, so there is no golden-output churn. - Simulated databricks#6525 and the `model_services` annotations are picked up This pull request and its description were written by Isaac. --------- Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds direct-engine Databricks Asset Bundle support for the Unity Catalog AI Gateway model service securable (model_services), so it can be declared and deployed from databricks.yml. First of a stacked split of #6410 (mcp_services and model_provider_services follow). Direct engine only.
Scope is strictly model_service: no changes to jobs suppression or other resources. Owner is deferred (the API returns effective_owner); permissions use grants; no Catalog Explorer URL is wired up yet.
Changes
Why
Tests