fix: avoid errors and add default empty string#202
Merged
Conversation
raphaelSeguin
requested review from
kerrerain and
sarod
and removed request for
sarod
|
📦 Web extension build artifacts: https://github.com/dataforgoodfr/14_BalanceTesHaters/actions/runs/24100723514/artifacts/6313903867 |
Collaborator
Author
|
Testé sur ces deux cas qui ne fonctionnaient pas : |
in case the comment is empty, defaults with empty string. In some cases, the comments container is not the third but the second div.
raphaelSeguin
force-pushed
the
fix/110-instagram-capture-fails-if-no-description
branch
from
8f378f2 to
5d4f619
Compare
sarod
reviewed
Mar 19, 2026
| HTMLElement, | ||
| return tryOrElse( | ||
| () => | ||
| this.scrapingSupport.selectOrThrow( |
Collaborator
There was a problem hiding this comment.
Je pense qu'utiliser this.scrapingSupport.select plutôt que faire un catch sur selectOrThrow serait plus simple ici.
Par exemple le code suivant serait équivalent
return this.scrapingSupport.select(element, ":scope span>div>span", HTMLElement)?.textContent || "";
| HTMLElement, | ||
| const commentsContainer = tryOrElse( | ||
| () => | ||
| this.scrapingSupport.selectOrThrow( |
Collaborator
There was a problem hiding this comment.
ici aussi select serait peut-être plus adapté.
|
|
||
| for (const comment of commentElements) { | ||
| comments.push(this.scrapCommentThread(comment)); | ||
| try { |
Collaborator
There was a problem hiding this comment.
Dans quel cas ce try -catch est-il utile?
Est-ce pour ajouter plus de résilience de manière générale ou pour gérer un cas en particulier?
| baseElement, | ||
| ":scope>div>div:nth-of-type(2)>span", | ||
| HTMLElement, | ||
| const postContent = tryOrElse( |
Collaborator
There was a problem hiding this comment.
je privilegierais là aussi select a la place de selctOrThrow + tryOrElse
in case the comment is empty, defaults with empty string. In some cases, the comments container is not the third but the second div.
…ithub.com:dataforgoodfr/14_BalanceTesHaters into fix/110-instagram-capture-fails-if-no-description
in case the comment is empty, defaults with empty string. In some cases, the comments container is not the third but the second div.
in case the comment is empty, defaults with empty string. In some cases, the comments container is not the third but the second div.
…ithub.com:dataforgoodfr/14_BalanceTesHaters into fix/110-instagram-capture-fails-if-no-description
sarod
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110
in case the comment is empty, defaults with empty string. In some cases, the comments container is not the third but the second div.