feat(iam): add LocationBinding ProtectedResource and viewer role#172
Merged
Conversation
LocationBinding had no IAM coverage: there was no ProtectedResource registering it with Milo IAM and no role granting any locationbindings permission. Because the IAM authorizer only authorizes registered ProtectedResources, locationbindings were denied to every identity except system:masters — so consumers/project owners could not read the LocationBindings projected into their own projects, despite the type being consumer-facing. Add: - a LocationBinding ProtectedResource (parented to resourcemanager.miloapis.com/Project, mirroring locations), and - a networking.datumapis.com-locationbinding-viewer role granting get/list/watch. This unblocks granting project owners read access to LocationBindings (wired into the owner role separately in datum-cloud/infra). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
kevwilliams
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Registers
LocationBindingwith Milo IAM and adds a read-only viewer role.ProtectedResourcenetworking.datumapis.com-locationbinding(plural: locationbindings), parented toresourcemanager.miloapis.com/Project, mirroring the existinglocationsProtectedResource.Rolenetworking.datumapis.com-locationbinding-viewergrantinglocationbindings.{list,get,watch}.config/iam/.../kustomization.yaml.Why
LocationBindinghad no IAM coverage: no ProtectedResource registered it, and no role granted anylocationbindings.*permission. Milo's IAM authorizer only authorizes resources registered as ProtectedResources, solocationbindingswere denied for every identity exceptsystem:masters. As a result, consumers / project owners could not list or read the LocationBindings projected into their own projects — even though the type is a consumer-facing projection of a Location into a project's control plane.Unblocks
A follow-up PR on
datum-cloud/infraappendsnetworking.datumapis.com-locationbinding-viewerto the projectownerrole so owners can read the LocationBindings in their own project (read-only, project-scoped).Validation
kubectl kustomize config/iambuilds cleanly and includes the new ProtectedResource and Role.🤖 Generated with Claude Code