Few simple ports to py3 in server scripts#16
Open
ChillerDragon wants to merge 2 commits intoddnet:masterfrom
Open
Few simple ports to py3 in server scripts#16ChillerDragon wants to merge 2 commits intoddnet:masterfrom
ChillerDragon wants to merge 2 commits intoddnet:masterfrom
Conversation
Member
|
Have you tested that this causes no issues with different unicode handling in python 3 compared to 2? |
9467b7d to
e97e674
Compare
Member
Author
Member
|
In my experience python2 to python3 conversions are not that easy because of the way strings are handled. |
5450b64 to
c6f0bf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.