Repository navigation
Conversation
ABACUS-PR-BOT
left a comment
There was a problem hiding this comment.
The generic BLAS/LAPACK discovery change drops a still-documented custom-path interface; please preserve it or provide an explicit migration.
Reviewed 6a3819b0de42 against 27c3e1065bfe through static source tracing, including affected CMake callers and CMake 3.18.6 finder contracts. git diff --check passed; configuration, builds, tests, and CI results remain unverified.
Non-blocking: Please add the exact verification commands and outcomes to the PR description, noting whether the pyabacus MKL path was exercised and which checks remain unrun.
ABACUS-PR-BOT
left a comment
There was a problem hiding this comment.
The obsolete arguments leave unused path settings in the four build helpers; the cleanup is noted inline.
Reviewed the 6a3819b0de42 → 4d16dcfdcba3 increment statically. git diff --check and the trusted governance check passed; configuration, builds, tests, and CI remain unverified.
GIT_SUBMODULESoptions as it's not used anywhere.abacus::mkl)LAPACK::LAPACKtarget is available since CMake version 3.18.The next steps will be done with a purpose of minimzing the use of custom helpers and definitions, e.g.
_abacus_feature_definitions,abacus_add_target_compile_requirementsetc. This would require:cmake_minimum_required()version bump would be substantial in order to meet the expectation (3.24+; most likely 3.27 to take use of compile context which will replaceabacus_add_target_compile_requirementsentirely)This cleanup series is expected to be completed before the official 3.11 release.