Skip to content

Revert "CI: pin numpy to <2.3 & rdkit to <2025.3.3"#921

Open
njzjz wants to merge 2 commits intodevelfrom
revert-837-fix-parmed-import
Open

Revert "CI: pin numpy to <2.3 & rdkit to <2025.3.3"#921
njzjz wants to merge 2 commits intodevelfrom
revert-837-fix-parmed-import

Conversation

@njzjz
Copy link
Member

@njzjz njzjz commented Jan 12, 2026

Reverts #837

Both issues have been fixed

Summary by CodeRabbit

  • Chores
    • Removed version constraints on chemistry and numeric dependencies in CI workflows (e.g., rdkit and numpy), switching to more permissive installs so the latest compatible package releases are used during automated tests.

Copilot AI review requested due to automatic review settings January 12, 2026 16:12
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 12, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 12, 2026

Merging this PR will improve performance by 11.76%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
✅ 1 untouched benchmark
⏩ 2 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime test_import 11.1 ms 10 ms +11.76%

Comparing revert-837-fix-parmed-import (4460213) with devel (4ae8b2c)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts a previous change (PR #837) that added temporary version constraints for numpy (<2.3) and rdkit (<2025.3.3) in CI workflows. According to the PR description, the underlying compatibility issues that necessitated these pins have now been resolved.

Changes:

  • Remove numpy and rdkit version constraints from the test workflow
  • Remove rdkit version constraint from the pyright workflow

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/test.yml Removes 'numpy<2.3' and 'rdkit<2025.3.3' version pins from CI dependencies
.github/workflows/pyright.yml Removes 'rdkit<2025.3.3' version pin from type checking workflow dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dosubot dosubot bot added the github_actions Pull requests that update GitHub Actions code label Jan 12, 2026
@njzjz njzjz marked this pull request as draft January 12, 2026 16:15
@njzjz
Copy link
Member Author

njzjz commented Jan 12, 2026

parmed released v4.3.1 but didn't upload it to pypi.

@coderabbitai
Copy link

coderabbitai bot commented Jan 12, 2026

📝 Walkthrough

Walkthrough

Removes version constraints from rdkit in .github/workflows/pyright.yml and rdkit plus numpy in .github/workflows/test.yml, changing pip install lines to use unconstrained package names.

Changes

Cohort / File(s) Summary
GitHub Actions — pyright workflow
\.github/workflows/pyright\.yml
Replaced rdkit<2025.3.3 (quoted) with an unconstrained rdkit in the pip install extras list.
GitHub Actions — test workflow
\.github/workflows/test\.yml
Removed version pins rdkit<2025.3.3 and numpy<2.3 from the pip install command and switched to unconstrained rdkit and openbabel-wheel installs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • wanghan-iapcm
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: reverting version constraints on numpy and rdkit in CI configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into devel

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-837-fix-parmed-import

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.github/workflows/pyright.yml:
- Line 16: The rdkit package was unpinned in the workflow command (the run step
installing packages), but RDKit 2025.03.3 is incompatible with NumPy 2.x;
restore a version constraint (e.g., rdkit<2025.3.3) in the install command used
in the run step to prevent installing the problematic release, keep the rest of
the packages unchanged, and add a brief inline comment referencing RDKit issue
#7477 so the pin is not removed until NumPy 2.0 compatibility is confirmed.
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2fa782d and 307eb67.

📒 Files selected for processing (2)
  • .github/workflows/pyright.yml
  • .github/workflows/test.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Upload results
🔇 Additional comments (1)
.github/workflows/test.yml (1)

29-29: LGTM - version constraints for rdkit and numpy removed.

The change removes both rdkit<2025.3.3 and numpy<2.3 pins as intended by this revert. Since the matrix tests against both Python 3.8 and 3.12, ensure that the upstream compatibility fixes work across both Python versions.

Verify the CI passes after this change, as the PR relies on upstream fixes being in place for both rdkit and numpy.

@njzjz njzjz closed this Feb 12, 2026
@njzjz njzjz reopened this Feb 12, 2026
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.27%. Comparing base (4ae8b2c) to head (4460213).

Additional details and impacted files
@@           Coverage Diff           @@
##            devel     #921   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files          86       86           
  Lines        8032     8032           
=======================================
  Hits         6930     6930           
  Misses       1102     1102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@njzjz njzjz marked this pull request as ready for review February 13, 2026 10:52
@njzjz njzjz requested a review from wanghan-iapcm February 13, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant