Revert "CI: pin numpy to <2.3 & rdkit to <2025.3.3"#921
Conversation
This reverts commit 8f8e6a5.
Merging this PR will improve performance by 11.76%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | test_import |
11.1 ms | 10 ms | +11.76% |
Comparing revert-837-fix-parmed-import (4460213) with devel (4ae8b2c)
Footnotes
-
2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
There was a problem hiding this comment.
Pull request overview
This PR reverts a previous change (PR #837) that added temporary version constraints for numpy (<2.3) and rdkit (<2025.3.3) in CI workflows. According to the PR description, the underlying compatibility issues that necessitated these pins have now been resolved.
Changes:
- Remove numpy and rdkit version constraints from the test workflow
- Remove rdkit version constraint from the pyright workflow
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test.yml | Removes 'numpy<2.3' and 'rdkit<2025.3.3' version pins from CI dependencies |
| .github/workflows/pyright.yml | Removes 'rdkit<2025.3.3' version pin from type checking workflow dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
parmed released v4.3.1 but didn't upload it to pypi. |
📝 WalkthroughWalkthroughRemoves version constraints from rdkit in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/pyright.yml:
- Line 16: The rdkit package was unpinned in the workflow command (the run step
installing packages), but RDKit 2025.03.3 is incompatible with NumPy 2.x;
restore a version constraint (e.g., rdkit<2025.3.3) in the install command used
in the run step to prevent installing the problematic release, keep the rest of
the packages unchanged, and add a brief inline comment referencing RDKit issue
#7477 so the pin is not removed until NumPy 2.0 compatibility is confirmed.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/pyright.yml.github/workflows/test.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Upload results
🔇 Additional comments (1)
.github/workflows/test.yml (1)
29-29: LGTM - version constraints for rdkit and numpy removed.The change removes both
rdkit<2025.3.3andnumpy<2.3pins as intended by this revert. Since the matrix tests against both Python 3.8 and 3.12, ensure that the upstream compatibility fixes work across both Python versions.Verify the CI passes after this change, as the PR relies on upstream fixes being in place for both rdkit and numpy.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #921 +/- ##
=======================================
Coverage 86.27% 86.27%
=======================================
Files 86 86
Lines 8032 8032
=======================================
Hits 6930 6930
Misses 1102 1102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Reverts #837
Both issues have been fixed
Summary by CodeRabbit