Fix DeepCompile+Z3 on PyTorch v2.9/2.10#7951
Open
tohtana wants to merge 5 commits intodeepspeedai:masterfrom
Open
Fix DeepCompile+Z3 on PyTorch v2.9/2.10#7951tohtana wants to merge 5 commits intodeepspeedai:masterfrom
tohtana wants to merge 5 commits intodeepspeedai:masterfrom
Conversation
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56479c3151
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
(cherry picked from commit c7f1b5cd3f84bf5cdc37a48515eaff5f06580fb4) Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeepCompile+Z3 didn't work with PyTorch v2.9/2.10 because:
param.dataisempty(0). That produced guard failures likeexpected 4096, actual 0.This PR resolves the issue by:
This PR also includes fixes of these bugs:
end_backwardahead of the realreduce_gradcalls. - Selective unsharding pass can overcount the persistence memory budget.Note: DeepCompile is still incompatible with v2.11. It will be addressed by another PR.