Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changepacks/changepack_log_V_c980ZHoX7fAHspd9P2y.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"changes":{"bridge/python/pyproject.toml":"Patch","crates/node/Cargo.toml":"Patch","crates/rust/Cargo.toml":"Patch","crates/core/Cargo.toml":"Patch","bridge/node/package.json":"Patch","crates/python/Cargo.toml":"Patch","crates/cli/Cargo.toml":"Patch"},"note":"Fix beta issue","date":"2026-05-11T13:12:56.396433700Z"}
10 changes: 5 additions & 5 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

80 changes: 80 additions & 0 deletions crates/cli/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,17 @@ fn compute_updates(
// resolved version to 2 segments before comparing. This respects the user's
// intent to pin only at that granularity.
let precision = count_version_segments(current_bare);

if precision < 3 && !is_plain_three_segment_version(selected) {
trace!(
package = %dep.name,
current = %dep.current_req,
selected = %selected,
"skipping: selected version cannot be safely truncated"
);
continue;
}

let selected_truncated = truncate_version(selected, precision);

if current_bare == selected_truncated {
Expand Down Expand Up @@ -406,6 +417,20 @@ fn count_version_segments(bare: &str) -> usize {
numeric_part.split('.').filter(|s| !s.is_empty()).count()
}

fn is_plain_three_segment_version(version: &str) -> bool {
let mut parts = version.split('.');
matches!(
(parts.next(), parts.next(), parts.next(), parts.next()),
(Some(major), Some(minor), Some(patch), None)
if !major.is_empty()
&& !minor.is_empty()
&& !patch.is_empty()
&& major.chars().all(|c| c.is_ascii_digit())
&& minor.chars().all(|c| c.is_ascii_digit())
&& patch.chars().all(|c| c.is_ascii_digit())
)
}

/// Truncate a version string to the given number of segments.
///
/// Always strips build metadata (the `+...` suffix) since it has no meaning
Expand Down Expand Up @@ -562,6 +587,42 @@ mod tests {
assert_eq!(updates[0].to, "2.0.0");
}

#[test]
fn test_compute_updates_does_not_truncate_prerelease_to_stable() {
let deps = vec![DependencySpec {
name: "pkg".to_owned(),
current_req: "3.1".to_owned(),
section: DependencySection::Dependencies,
}];
let resolved = vec![(
0,
Ok(ResolvedVersion {
latest: Some("3.1.0".to_owned()),
selected: Some("4.0.0-beta.0".to_owned()),
}),
)];
let updates = compute_updates(&deps, &resolved);
assert!(updates.is_empty());
}

#[test]
fn test_compute_updates_truncates_plain_three_segment_version() {
let deps = vec![DependencySpec {
name: "pkg".to_owned(),
current_req: "3.1".to_owned(),
section: DependencySection::Dependencies,
}];
let resolved = vec![(
0,
Ok(ResolvedVersion {
latest: Some("4.0.0".to_owned()),
selected: Some("4.0.0".to_owned()),
}),
)];
let updates = compute_updates(&deps, &resolved);
assert_eq!(updates[0].to, "4.0");
}

#[test]
fn test_compute_updates_skips_failed_resolution() {
let deps = vec![DependencySpec {
Expand Down Expand Up @@ -980,6 +1041,25 @@ mod tests {
assert_eq!(updates[0].to, "2.0.0-rc.40");
}

#[test]
fn test_compute_updates_allows_beta_to_newer_beta_upgrade() {
let deps = vec![DependencySpec {
name: "pkg".to_owned(),
current_req: "4.0.0-beta.0".to_owned(),
section: DependencySection::Dependencies,
}];
let resolved = vec![(
0,
Ok(ResolvedVersion {
latest: Some("4.0.0-beta.2".to_owned()),
selected: Some("4.0.0-beta.2".to_owned()),
}),
)];
let updates = compute_updates(&deps, &resolved);
assert_eq!(updates.len(), 1);
assert_eq!(updates[0].to, "4.0.0-beta.2");
}

#[test]
fn test_compute_updates_allows_prerelease_to_stable_upgrade() {
// Current: 2.0.0-rc.37 (prerelease), Selected: 2.0.0 (stable) → semver: stable > prerelease of same version.
Expand Down
Loading