Merged
Conversation
Add branding (colors, logo) and meta (OG tags, analytics) config sections. Add core_contributors property with devseed fallback for backward compat. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Also fixes a pre-existing ruff E501 line-length violation in config.py. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add pa- prefix and .js suffix to the analytics script URL to match the original format.
…nalytics_id to top level Remove MetaConfig model and [meta] TOML section. Move analytics_id to top-level config. Remove unused logo field from BrandingConfig. OG/social sharing tags deferred to #98.
Make it explicit that this field is for Plausible analytics. Users with other analytics tools can customize the template directly.
Only used in an invisible meta tag. Not worth configuring.
- Remove devseed fallback from core_contributors property - Remove devseed_contributors backward-compat alias - Rename CSS class legend-swatch--devseed to --org - Replace DevSeed in comments, test fixtures, and fallback strings - Clear Development Seed fallback in main.ts
Remove accidentally committed firzaariany.json link file and restore links.csv to its state on main.
Move title, theme-color, and Plausible analytics injection to main.ts at runtime. Removes the Jinja2 dependency and the dual-entrypoint problem where both index.html and index.html.j2 needed to be managed. index.html is now the single source of truth again.
Contributor
|
✨ Preview deployed to S3! Visit http://ds-preview-contributor-network-99.s3-website-us-west-2.amazonaws.com/ |
This was
linked to
issues
Apr 2, 2026
gadomski
requested changes
Apr 2, 2026
Collaborator
gadomski
left a comment
gadomski
left a comment
There was a problem hiding this comment.
LMK if any of the code-based comments are confusing and we can chat through 'em
Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
Member
Author
|
@gadomski let me know if I misunderstood your comments or implemented them incorrectly. I also added the environment variable for Plausible so that should work when this deploys. |
gadomski
requested changes
Apr 3, 2026
Collaborator
gadomski
left a comment
gadomski
left a comment
There was a problem hiding this comment.
I took the liberty of adding the environment variable to the github actions ... I see that it's a secret right now, can you switch PLAUSIBLE_ID to be a variable instead? It's not secret, b/c it's embedded in the website when we deploy it.
Member
Author
|
ah whoops. totally read secrets instead. updated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This centralizes all the necessary config to config.toml and scrubs all DevSeed references from variable names or hardcoded into text. It should result in no visible change on the frontend, but prepares us to be able to clone the repo for a NASA-specific version without DevSeed's fingerprints all over it.
config.toml should include: