fix: add the initial step for the devfile registry guide#268
Merged
michael-valdron merged 2 commits intodevfile:mainfrom Sep 23, 2025
Merged
fix: add the initial step for the devfile registry guide#268michael-valdron merged 2 commits intodevfile:mainfrom
michael-valdron merged 2 commits intodevfile:mainfrom
Conversation
Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
michael-valdron
requested changes
Sep 22, 2025
Member
michael-valdron
left a comment
michael-valdron
left a comment
There was a problem hiding this comment.
Thanks for your contribution @pratik-mahalle!
I've left a bit of feedback on your initial step addition.
libs/docs/src/docs/no-version/building-a-custom-devfile-registry.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, pratik-mahalle The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/ok-to-test |
Member
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Added a missing step in the manual for building a custom registry to instruct users to first clone the
[registry-support](https://github.com/devfile/registry-support)repository and navigate to thebuild-toolsfolder before running thebuild_image.shscript.This ensures new contributors know where the script is located and can run it successfully.
Related Issue(s)
Fixes: [devfile/registry#<ISSUE_NUMBER>]
(Replace
<ISSUE_NUMBER>with the actual issue number you are working on)Acceptance Criteria
Update the [sidebar](https://github.com/devfile/devfile-web/tree/main/apps/landing-page#configuring-navigation) if there is a new file added or an existing filename is changed
Tests Performed
registry-supportrepository locally.build-toolsand successfully ran./build_image.shusing a sample registry content directory to confirm the steps work as expected.How To Test
registry-supportandcdintobuild-tools)../build_image.sh <path-to-registry-content>command.Notes To Reviewer
This is a documentation-only change aimed at improving clarity for new contributors.
No code, configuration, or functionality is affected.