test: stop validating all blocks when maliciously_notarize_all flag is set#9000
Merged
kpop-dfinity merged 5 commits intomasterfrom Feb 24, 2026
Merged
test: stop validating all blocks when maliciously_notarize_all flag is set#9000kpop-dfinity merged 5 commits intomasterfrom
maliciously_notarize_all flag is set#9000kpop-dfinity merged 5 commits intomasterfrom
Conversation
kpop-dfinity
changed the title
kpop-dfinity
changed the title
maliciously_notarize_all flag is set
Co-authored-by: Pierugo Pace <pierugo.pace@dfinity.org>
eichhorl
approved these changes
Feb 24, 2026
Contributor
eichhorl
left a comment
eichhorl
left a comment
There was a problem hiding this comment.
Did you check it the test is less flaky now?
Contributor
Author
I did run several tests, but even without the change the test never failed for me... It seems that it's flaky but with low probability... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes a node with this malicious behavior would crash itself because of this