chore(docs): correct namespace examples in README #284
+33
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR corrects inaccurate namespace API examples in the README documentation to match the actual function signatures in the codebase. The corrections ensure that users will see the proper way to capture the namespace ID from CreateNamespace and pass it to DropNamespace.
- Updated
CreateNamespaceexample to capture the returned namespace ID - Updated
DropNamespaceexample to pass the required namespace ID parameter - Updated CODEOWNERS team assignment (unrelated to main purpose)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Corrected namespace API examples to match actual function signatures: CreateNamespace now captures the returned nsID, and DropNamespace now includes the required nsID parameter |
| .github/CODEOWNERS | Changed code owner team from @hypermodeinc/database to @hypermodeinc/maintainers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…rotos on non-Linux systems This preserves the requisite gRPC versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR corrects inaccuracies in the namespace examples in the README. There is also an added test to ensure proper enforcement of user credentials when using the namespace connection string parameter.