SMV: split type checking out of convert_defines#1623
Merged
tautschnig merged 1 commit intomainfrom Feb 5, 2026
Merged
Conversation
This splits up the convert_defines method, to separate conversion from type checking.
tautschnig
approved these changes
Feb 5, 2026
|
|
||
| void collect_define(const exprt &lhs, const exprt &rhs); | ||
| void typecheck_defines(); | ||
| void typecheck_define(define_mapt::iterator); |
Collaborator
There was a problem hiding this comment.
For future consideration: I find passing around an iterator pretty opaque and would have preferred passing around two parameters: a (const) key const irep_idt& identifier and a (non-const) definet &d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits up the
convert_definesmethod, to separate conversion from type checking.