Repository navigation
Correct stale comments in focus-step, Door, peer-surfaces, the dor launchers, and PRODUCT.md - #1096
Merged
Merged
Conversation
Fixes comments whose pointers or claims no longer match the code, and asserts the preview-mark half of a tool-run-end test title.
Deploying mouseterm with
|
| Latest commit: |
8cee7e8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d72205e8.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-stale-comments-nightly.mouseterm.pages.dev |
dormouse-bot
requested a deployment
to
hosted-preview
October 10, 2026 12:43 — with
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects comments that no longer match the code or that point at the wrong spec. It changes no behavior. One test gains the assertion its title already promised.
lib/src/components/focus-step.ts: the docstring named a "pane header context menu" as astepFocuscaller. No such caller exists. The real ones are the modal and popover focus traps, the terminal context detail, and the Workspace tab menu.lib/src/components/Door.tsx: thespokenbadge comment pointed atdocs/specs/layout.md. That spec defers todocs/specs/alert.md→ Door, which is where theSPOKENrule lives.lib/src/remote/burrow/peer-surfaces.ts: "attach-is-the-resize" does not appear inremote-api.md. The comment now cites the heading that states the rule, "Size authority: last-attach-wins".website/src/lib/playground-fs/viewers.ts:searchis the rawurl.searchstring thatsw.jssends, not aURLSearchParams.dor/bin/doranddor/bin/dor.cmd: the comments saidDORMOUSE_NODEis always Electron. It is Electron only under VS Code; standalone passes a plain Node binary (docs/specs/dor-cli.md→ Public PTY env), which ignoresELECTRON_RUN_AS_NODE.PRODUCT.md: removed the sentence calling "the current Catppuccin Mocha design" throwaway. Nothing in the tree uses Catppuccin anymore.lib/src/components/wall/tool-run-end.test.tsx: the test "keeps a user rename through the end, and drops a preview mark with the Tool" never checked the preview mark. It now assertsparamsis gone, the same way the neighbouring test does. It passes locally (16/16).