Skip to content

Correct stale comments in focus-step, Door, peer-surfaces, the dor launchers, and PRODUCT.md - #1096

Merged
nedtwigg merged 1 commit into
mainfrom
fix/stale-comments-nightly
Oct 11, 2026
Merged

nedtwigg merged 1 commit into
mainfrom
fix/stale-comments-nightly

Conversation

@dormouse-bot

Copy link
Copy Markdown
Collaborator

This PR corrects comments that no longer match the code or that point at the wrong spec. It changes no behavior. One test gains the assertion its title already promised.

  • lib/src/components/focus-step.ts: the docstring named a "pane header context menu" as a stepFocus caller. No such caller exists. The real ones are the modal and popover focus traps, the terminal context detail, and the Workspace tab menu.
  • lib/src/components/Door.tsx: the spoken badge comment pointed at docs/specs/layout.md. That spec defers to docs/specs/alert.md → Door, which is where the SPOKEN rule lives.
  • lib/src/remote/burrow/peer-surfaces.ts: "attach-is-the-resize" does not appear in remote-api.md. The comment now cites the heading that states the rule, "Size authority: last-attach-wins".
  • website/src/lib/playground-fs/viewers.ts: search is the raw url.search string that sw.js sends, not a URLSearchParams.
  • dor/bin/dor and dor/bin/dor.cmd: the comments said DORMOUSE_NODE is always Electron. It is Electron only under VS Code; standalone passes a plain Node binary (docs/specs/dor-cli.md → Public PTY env), which ignores ELECTRON_RUN_AS_NODE.
  • PRODUCT.md: removed the sentence calling "the current Catppuccin Mocha design" throwaway. Nothing in the tree uses Catppuccin anymore.
  • lib/src/components/wall/tool-run-end.test.tsx: the test "keeps a user rename through the end, and drops a preview mark with the Tool" never checked the preview mark. It now asserts params is gone, the same way the neighbouring test does. It passes locally (16/16).

Fixes comments whose pointers or claims no longer match the code, and
asserts the preview-mark half of a tool-run-end test title.
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8cee7e8
Status: ✅  Deploy successful!
Preview URL: https://d72205e8.mouseterm.pages.dev
Branch Preview URL: https://fix-stale-comments-nightly.mouseterm.pages.dev

View logs

@nedtwigg
nedtwigg merged commit 4f03926 into main Oct 11, 2026
16 of 17 checks passed

This branch is waiting to be deployed

1 waiting deployment
hosted-preview — 8cee7e8e Waiting Oct 10, 2026 by dormouse-bot via deploy #1279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants