Repository navigation
Conversation
A click on a pane whose ring was still deferred behind animation turned it straight into a TODO, so a summons skipped to its receipt without ever ringing. A ring that never showed has summoned no one: a look, `a`, `t`, and the pill now leave it deferred, to come due as a hold if the user is still engaged or a ring if not. Typing still answers it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
State the rule once on clearRingForUser and Ring.shown, drop the input flag threaded through setTodoForUser, and pin the rule in one suite. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A ring deferred since it opened stays a fresh completion until it shows: the hold-on-reveal rule and the survives-every-verb-but-input rule are one concept, so Completion events owns it and Clearing And TODO points there; their rationale entries merge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
9555900
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://959ba516.mouseterm.pages.dev |
| Branch Preview URL: | https://alert-look-keeps-deferral.mouseterm.pages.dev |
dormouse-bot
approved these changes
Oct 11, 2026
nedtwigg
requested a deployment
to
hosted-preview
October 11, 2026 19:26 — with
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A click on a pane whose ring was still deferred behind animation turned it straight into a TODO, so the summons skipped to its receipt without ever ringing. Seen as: background work looks unfinished with no ring and no TODO; clicking it to check shows it finished, and the click itself leaves a TODO.
A ring deferred since it opened has summoned no one, so it now stays a fresh completion until it shows:
a,t, and the TODO pill leave it deferred. When the detector goes quiet, engagement decides as at dispatch: a hold (TODO at once) if the user is still engaged, a ring if not.clearRingForUserinlib/src/lib/alert-manager.tscarries the rule, gated on the existingRing.shown. Indocs/specs/alert.md, Completion events now owns it as one rule (it absorbs the existing hold-on-reveal rule) and Clearing And TODO points there; the rationale entries merge. The Clearing And TODO table folds acknowledge-without-input and dismiss into one row, and the persisted-ring rule no longer says "the TODO a look would leave", since a look no longer leaves one for a never-shown deferred ring.Tests in
lib/src/lib/alert-engagement.test.tscover a look while still engaged, a look then leaving, every verb but input, and a shown-then-deferred ring; each goes red with its line of the fix reverted. Twoalert-manager.test.tscases that pinned the old behavior are removed as duplicates.🤖 Generated with Claude Code