style: set the line width limit to 79#164
style: set the line width limit to 79#164sbillinge merged 4 commits intodiffpy:mainfrom ycexiao:line_width
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
=======================================
Coverage 96.85% 96.85%
=======================================
Files 18 18
Lines 795 795
=======================================
Hits 770 770
Misses 25 25
|
|
@sbillinge @bobleesj It's ready for review. Please see if it is right. |
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
looks good. Please see comments.
news/line79.rst
Outdated
|
|
||
| **Changed:** | ||
|
|
||
| * reduce the line width limit to 79 |
There was a problem hiding this comment.
This would be considered a fix, not a change. A change is reserved for a change in behavior that a user might need to know about.
| 1 | ||
| - 3 * r / (4 * d * v) * (1 - r2 / (4 * d2) * (1 + 2.0 / (3 * v2))) | ||
| - 3 * r / (4 * d) * (1 - r2 / (4 * d2)) * v / sqrt(1 - v2) * atanh(sqrt(1 - v2)) | ||
| - 3 |
There was a problem hiding this comment.
this line is probably more readable longer. I would return it back and # noqa it I htink it is 501 code.
| ( | ||
| 3 * d / (8 * r) * (1 + r2 / (2 * d2)) * sqrt(1 - r2 / d2) | ||
| - 3 * r / (4 * d) * (1 - r2 / (4 * d2)) * atanh(sqrt(1 - r2 / d2)) | ||
| - 3 |
| 1 | ||
| - 3 * r / (4 * d * v) * (1 - r2 / (4 * d2) * (1 + 2.0 / (3 * v2))) | ||
| - 3 * r / (4 * d) * (1 - r2 / (4 * d2)) * v / sqrt(v2 - 1) * atan(sqrt(v2 - 1)) | ||
| - 3 |
|
@sbillinge news.rst has modified. Now I understand About the equation formatting. I found it will be more readable if we use less space or new-line and only separate operations with the lowest priority. Please check if it is suitable. |
2 participants
close #163