Allow passing AVAsset to waveform analyzer#110
Merged
dmrschmidt merged 1 commit intodmrschmidt:mainfrom Jan 22, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for passing AVAsset directly to WaveformAnalyzer, allowing callers to reuse existing asset instances instead of creating multiple assets for the same file. The existing URL-based API is refactored to delegate to the new asset-based method, and an unused parameter is removed from an internal helper method.
Changes:
- Added new public
samples(fromAsset:count:qos:)method acceptingAVAssetparameter - Refactored existing
samples(fromAudioAt:count:qos:)to delegate to the new method - Removed unused
assetReaderparameter from internalprocessmethod
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Thanks for your contribution, this makes sense :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow passing
AVURLAssetdirectly toWaveformAnalyzerinstead ofURL, so I don't create multiple assets pointing to the same file.