fix(table): decorate resumed history tables lazily on scroll - #260
Open
jinwei233 wants to merge 1 commit into
Open
fix(table): decorate resumed history tables lazily on scroll#260jinwei233 wants to merge 1 commit into
jinwei233 wants to merge 1 commit into
Conversation
Resumed sessions eagerly decorate only the hot tail, so tables above it stayed raw Markdown forever -- fontification recovers via jit-lock on scroll, but table decoration had no such hook. Register pi-coding-agent--jit-decorate-tables with jit-lock so pipe tables are decorated on the same redisplay pass that fontifies each region as it scrolls into view. jit-lock chunks can bisect a table, so the region is expanded to whole tree-sitter pipe_table extents before decorating; the existing decoration path is reused so fenced-code skipping, header-only deferral, the prettify toggle, and the raw-toggle guard all still apply. No load-time cost: work happens only on redisplay of visible regions. Adds four ERT tests; correct two history-path docstrings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Register table decoration with
jit-lockso older tables in resumed sessions become prettified when they scroll into view. Resumed history still eagerly processes only the hot tail, preserving load performance.How
pi-coding-agent--jit-decorate-tables.pipe_tablebounds before decoration.pi-coding-agent--restore-tool-properties.Testing
masterbaseline.git diff --checkpasses.