Skip to content

Conversation

@barbirict
Copy link
Contributor

This PR adds support for dual stack in the service. Before this PR it had to be set by manually editing the service config.
Closes #195

@barbirict barbirict force-pushed the feat/ip-family-policy-in-service branch 2 times, most recently from 357d6b8 to d4c5226 Compare December 25, 2025 18:49
@cfis
Copy link
Collaborator

cfis commented Dec 27, 2025

Thanks for adding this feature. But the PR contains a lot of unrelated whitespace changes. I'm ok with those also too, but this should at a minimum be 2 separate commits (or 2 PRs). Can you split it up?

@barbirict
Copy link
Contributor Author

Thanks for adding this feature. But the PR contains a lot of unrelated whitespace changes. I'm ok with those also too, but this should at a minimum be 2 separate commits (or 2 PRs). Can you split it up?

Yeah sure, I'll split it up no problem :).

@Roger-Roger-debug
Copy link
Contributor

This is all that's needed on the service side I think. One small note: Order determines preference when ipFamilyPolicy is PreferDualStack I think this applies to RequireDualStack as well?

@barbirict
Copy link
Contributor Author

This is all that's needed on the service side I think. One small note: Order determines preference when ipFamilyPolicy is PreferDualStack I think this applies to RequireDualStack as well?

Yes you are correct, I made a typo. Will fix :).

@barbirict barbirict force-pushed the feat/ip-family-policy-in-service branch from d4c5226 to b73f959 Compare December 27, 2025 15:47
@barbirict
Copy link
Contributor Author

@cfis it's done!

@cfis
Copy link
Collaborator

cfis commented Dec 27, 2025

Hmm, seems the same to me? But fine, I merged it. Thanks for the PR.

I saw you linked to #195. Seems like there would be some addition work in configuring dovecot?

@cfis cfis merged commit f641031 into docker-mailserver:master Dec 27, 2025
5 checks passed
@barbirict
Copy link
Contributor Author

Hmm, seems the same to me? But fine, I merged it. Thanks for the PR.

I saw you linked to #195. Seems like there would be some addition work in configuring dovecot?

Hi thanks. Yeah I will look into dovecot and see what is there to do in the coming days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow configuring ipv6 in helm chart?

3 participants