add 'configured' event at the end of model configuration phase #13446
+15
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
force-pushed
the
fix-model-configured-display
branch
from
77d3470 to
3a769d3
Compare
ndeloof
previously approved these changes
Dec 12, 2025
Currently when using models, the final message is 'confugiring' which could let users think the DMR configuration is still pending Signed-off-by: Guillaume Lours <[email protected]> # Conflicts: # pkg/api/event.go
glours
force-pushed
the
fix-model-configured-display
branch
from
3a769d3 to
ed20330
Compare
ndeloof
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using models, the final message is 'confugiring' which could let users think the DMR configuration is still pending
What I did
Add new Status messages for the model life cycle and add a
Doneevent withconfiguredmessageRelated issue
N/A
(not mandatory) A picture of a cute animal, if possible in relation to what you did
