Add regression test for extends+include inheritance#13623
Open
infraAnchor wants to merge 1 commit intodocker:mainfrom
Open
Add regression test for extends+include inheritance#13623infraAnchor wants to merge 1 commit intodocker:mainfrom
infraAnchor wants to merge 1 commit intodocker:mainfrom
Conversation
Fixes docker#13606 Add test to verify that services using 'extends' properly inherit environment variables from base services when those base services get attributes from an 'include' directive. The test creates a scenario where: - compose.a.yml defines a web service with environment variable A - compose.b.yml includes compose.a.yml and defines a worker service that extends the web service with additional variables B and C The worker service should inherit all three variables (A, B, C), not just the ones defined locally (B, C). This test will pass once compose-go processes includes before extends. Signed-off-by: infraanchor <olaitanfalolu02@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13606
Add test to verify that services using 'extends' properly inherit environment variables from base services when those base services get attributes from an 'include' directive.
Test Scenario:
Expected:
The worker service should inherit all three variables (A, B, C), not just the ones defined locally (B, C).
Note:
This test will pass once compose-spec/compose-go processes includes before extends. Related PR pending in compose-go repository.