Skip to content

Fix TTY timer rendering when duration length changes #13634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaybeSam05 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

Fix TTY timer rendering when duration length changes #13634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions cmd/display/tty.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,18 @@ func (w *ttyWriter) printWithDimensions(terminalWidth, terminalHeight int) {
}
}

// pad timers so they all have the same visible width
for i := range lines {
l := &lines[i]
if l.timer == "" {
continue
}
timerWidth := utf8.RuneCountInString(l.timer)
if timerWidth < timerLen {
l.timer = l.timer + strings.Repeat(" ", timerLen-timerWidth)
}
}

// shorten details/taskID to fit terminal width
w.adjustLineWidth(lines, timerLen, terminalWidth)

Expand Down