Conversation
…e environment Signed-off-by: hiroto.toyoda <hiroto.toyoda@dena.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
getEnvironmentincmd/compose/run.gosilently returned(nil, nil)wheneverdotenv.ParseWithLookupfailed to parse an--env-from-file(e.g. arequired-variable reference like
${VAR:?message}that can't resolve). Becausethe error was swallowed,
runRuntreated the call as successful and thecontainer started with an empty environment — including variables passed
via
-e— with no error shown to the user.This PR:
os.Open, which was previously never closedcmd/compose/run_test.go(no unit tests existed forrun.gobefore), covering:e/-env-from-filemerge precedence, a missing file, and a malformed file — the last case reproduces the original bug and would have failed before this fixNo behavior change for the success path; only the error path changes from
"silently continue with an empty environment" to "return an error".
Related issue
N/A
(not mandatory) A picture of a cute animal, if possible in relation to what you did
🐈🐈🐈