docs: say swarm drain does not wait for replacement tasks - #25871
Open
locker95 wants to merge 1 commit into
Open
docs: say swarm drain does not wait for replacement tasks#25871locker95 wants to merge 1 commit into
locker95 wants to merge 1 commit into
Conversation
Signed-off-by: Dean Chen <862469039@qq.com>
github-actions
Bot
added
area/engine
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The drain tutorial says the manager stops tasks on the node and launches replicas on an active node. That's true, but it doesn't wait for those replacements to be running first — so you can dip under
--replicas, and draining the last worker takes everything down at once.Added that to the existing note.
@netlify /engine/swarm/swarm-tutorial/drain-node/
Fixes #9917