build/bake: fail fast on dependency signature verification errors#252
Merged
crazy-max merged 1 commit intoJul 18, 2026
Merged
Conversation
crazy-max
force-pushed
the
fix-dependency-signature-verification
branch
2 times, most recently
from
July 15, 2026 08:52
1a53399 to
d7d0dcd
Compare
Member
Author
tonistiigi
approved these changes
Jul 17, 2026
| }); | ||
| } catch (error) { | ||
| core.setFailed(`Failed to verify ${image}: ${error.message || error}`); | ||
| break; |
Member
There was a problem hiding this comment.
nit: this could just be return?
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
fix-dependency-signature-verification
branch
from
July 18, 2026 14:39
d7d0dcd to
892d4f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to https://github.com/crazy-max/xgo/actions/runs/29336003773/job/87096835413?pr=198#step:4:1
Dependency signature verification now reports failures after the log group closes so the error is visible in the workflow step summary.
The verification loop now rethrows the first failure instead of only marking the action as failed, which stops later dependency checks from running after an invalid signature result.
Also looking at the error:
It seems cosign is not able to download tuf (probably flaky network). This could be solved with docker/actions-toolkit#1133.