Zookeeper: Relinquish locks on session close #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The zookeeper store implements locking by using ephermeral nodes. On session close, all ephemeral nodes created by a client are removed, which means that other clients can acquire the lock. Previously, the zookeeper store failed to notify clients that the lock had been relinquished due to the session being closed (due to expiration or otherwise). Which means that the clients would continue execution while believing (wrongfully) that they still hold the lock. Now, the zookeeper store monitors the state of the session and notifies clients that the lock has been lost when the session is closed. Signed-off-by: Daniel Ferstay <[email protected]>
Author
|
The CI failure is fixed by #154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zookeeper store implements locking by using ephermeral nodes. On
session close, all ephemeral nodes created by a client are removed, which
means that other clients can acquire the lock.
Previously, the zookeeper store failed to notify clients that the lock had
been relinquished due to the session being closed (due to expiration or
otherwise). Which means that the clients would continue execution while
believing (wrongfully) that they still hold the lock.
Now, the zookeeper store monitors the state of the session and notifies
clients that the lock has been lost when the session is closed.
Signed-off-by: Daniel Ferstay [email protected]