[typescript-operations] Remove inputmaybe and scalars#10509
Merged
eddeee888 merged 2 commits intodotansimha:master-nextfrom Nov 24, 2025
Merged
[typescript-operations] Remove inputmaybe and scalars#10509eddeee888 merged 2 commits intodotansimha:master-nextfrom
eddeee888 merged 2 commits intodotansimha:master-nextfrom
Conversation
🦋 Changeset detectedLatest commit: bbaed46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eddeee888
reviewed
Nov 19, 2025
packages/plugins/typescript/operations/src/ts-operation-variables-to-object.ts
Outdated
Show resolved
Hide resolved
eddeee888
reviewed
Nov 19, 2025
eddeee888
reviewed
Nov 19, 2025
packages/plugins/typescript/operations/src/ts-operation-variables-to-object.ts
Outdated
Show resolved
Hide resolved
Collaborator
|
Thank you! Looking like it's on the right track! There are just a few minor missing things:
|
Contributor
Author
|
Thank you for your help! |
Contributor
Author
|
I have added the changes that we discussed. Could you please check?
|
Collaborator
|
Thank you!! |
10 tasks
eddeee888
pushed a commit
that referenced
this pull request
Jan 6, 2026
* [typescript-operations] Remove generation of InputMaybe and Scalars for variables * Adding support for `config.scalars`, fixing intergation tests --------- Co-authored-by: Igor Kusakov <igor@kusakov.com>
eddeee888
pushed a commit
that referenced
this pull request
Jan 20, 2026
* [typescript-operations] Remove generation of InputMaybe and Scalars for variables * Adding support for `config.scalars`, fixing intergation tests --------- Co-authored-by: Igor Kusakov <igor@kusakov.com>
eddeee888
pushed a commit
that referenced
this pull request
Feb 25, 2026
* [typescript-operations] Remove generation of InputMaybe and Scalars for variables * Adding support for `config.scalars`, fixing intergation tests --------- Co-authored-by: Igor Kusakov <igor@kusakov.com>
eddeee888
pushed a commit
that referenced
this pull request
Mar 3, 2026
* [typescript-operations] Remove generation of InputMaybe and Scalars for variables * Adding support for `config.scalars`, fixing intergation tests --------- Co-authored-by: Igor Kusakov <igor@kusakov.com>
ikusakov2
added a commit
to ikusakov2/graphql-code-generator
that referenced
this pull request
Mar 4, 2026
* [typescript-operations] Remove generation of InputMaybe and Scalars for variables * Adding support for `config.scalars`, fixing intergation tests --------- Co-authored-by: Igor Kusakov <igor@kusakov.com>
eddeee888
pushed a commit
that referenced
this pull request
Mar 8, 2026
* [typescript-operations] Remove generation of InputMaybe and Scalars for variables * Adding support for `config.scalars`, fixing intergation tests --------- Co-authored-by: Igor Kusakov <igor@kusakov.com>
eddeee888
pushed a commit
that referenced
this pull request
Mar 8, 2026
* [typescript-operations] Remove generation of InputMaybe and Scalars for variables * Adding support for `config.scalars`, fixing intergation tests --------- Co-authored-by: Igor Kusakov <igor@kusakov.com>
eddeee888
pushed a commit
that referenced
this pull request
Mar 8, 2026
* [typescript-operations] Remove generation of InputMaybe and Scalars for variables * Adding support for `config.scalars`, fixing intergation tests --------- Co-authored-by: Igor Kusakov <igor@kusakov.com>
eddeee888
pushed a commit
that referenced
this pull request
Mar 12, 2026
* [typescript-operations] Remove generation of InputMaybe and Scalars for variables * Adding support for `config.scalars`, fixing intergation tests --------- Co-authored-by: Igor Kusakov <igor@kusakov.com>
eddeee888
pushed a commit
that referenced
this pull request
Mar 19, 2026
* [typescript-operations] Remove generation of InputMaybe and Scalars for variables * Adding support for `config.scalars`, fixing intergation tests --------- Co-authored-by: Igor Kusakov <igor@kusakov.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We want to decoupe typescipt-operations from typescript plugin.
This PR removes InputMaybe and Scalars from generated variables.
Related #10496
Details
packages/plugins/typescript/operations/src/ts-operation-variables-to-object.tsgetScalaris an override to render normal typescript types instead ofScalars[...][...]. It takes into accountconfig.scalarswrapMaybeandclearOptionalfunctions are complementary: one appends a suffix; the other strips it.clearOptionalfunction visibility inpackages/plugins/typescript/typescript/src/typescript-variables-to-object.tsso it is possible to override it.Type of change
How Has This Been Tested?