Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the missing Roslyn Analyzers (SDL) step to the csproj-based OneBranch package job template so extension package jobs follow the same security analysis pattern already used by SqlClient and the AKV provider builds.
Changes:
- Run
RoslynAnalyzers@3inbuild-signed-csproj-package-job.ymlbefore the package build/signing steps. - Configure the analyzer run to build the appropriate
build.projtarget withReferenceType=Packageand the job’s version properties.
paulmedynski
approved these changes
Feb 26, 2026
mdaigle
approved these changes
Feb 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #3987 +/- ##
===========================================
- Coverage 75.22% 64.43% -10.79%
===========================================
Files 266 282 +16
Lines 42932 65951 +23019
===========================================
+ Hits 32294 42494 +10200
- Misses 10638 23457 +12819
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Roslyn Analyzers SDL step to csproj-based OneBranch package jobs
The OneBranch pipeline job template for csproj-based extension packages (
build-signed-csproj-package-job.yml) was missing theRoslynAnalyzers@3SDL security analysis step that is already present for the mainSqlClientandAKVProvider builds.This change adds the missing step, bringing the Abstractions, Azure, Logging, and SqlServer package jobs into parity with the existing SDL compliance pattern used across the pipeline.