Skip to content

Temporarily prevent API Scan from breaking our new OneBranch Official pipeline runs#3990

Merged
paulmedynski merged 1 commit intomainfrom
dev/paul/apiscan-official-no-break
Feb 27, 2026
Merged

Temporarily prevent API Scan from breaking our new OneBranch Official pipeline runs#3990
paulmedynski merged 1 commit intomainfrom
dev/paul/apiscan-official-no-break

Conversation

@paulmedynski
Copy link
Contributor

Description

There is some further setup required for API Scan to be happy with our new NuGet packages. This shouldn't hold up Preview 4, so I have disabled the breaking feature to allow our Official pipeline to get past the API Scan checks.

@paulmedynski paulmedynski added this to the 7.0.0-preview4 milestone Feb 27, 2026
Copilot AI review requested due to automatic review settings February 27, 2026 15:00
@paulmedynski paulmedynski requested a review from a team as a code owner February 27, 2026 15:00
@paulmedynski paulmedynski added the Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. label Feb 27, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR temporarily disables the breaking behavior of API Scan in the official OneBranch pipeline to unblock the Preview 4 release. The change sets break: false for the apiscan SDL configuration while adding a TODO comment that references work item 42858 and explains the required follow-up actions (registering new packages with API Scan and publishing documentation).

Changes:

  • Temporarily disabled API Scan breaking the official pipeline build to unblock Preview 4 release while setup work is completed

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.75%. Comparing base (2da1c76) to head (4ed9ae8).
⚠️ Report is 3 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (2da1c76) and HEAD (4ed9ae8). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (2da1c76) HEAD (4ed9ae8)
CI-SqlClient 2 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3990      +/-   ##
==========================================
- Coverage   74.43%   64.75%   -9.68%     
==========================================
  Files         287      282       -5     
  Lines       43965    66073   +22108     
==========================================
+ Hits        32725    42787   +10062     
- Misses      11240    23286   +12046     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 64.75% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmedynski paulmedynski merged commit a561ed3 into main Feb 27, 2026
300 checks passed
@paulmedynski paulmedynski deleted the dev/paul/apiscan-official-no-break branch February 27, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants