Add detailed specifications for new checks in aspire doctor command based on gh issues #13677
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13677Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13677" |
| **Priority:** Medium | ||
| **Source:** [Discussion #9739](https://github.com/dotnet/aspire/discussions/9739) | ||
|
|
||
| Docker Desktop Resource Saver mode can cause "container runtime appears unhealthy" warnings. |
There was a problem hiding this comment.
I am skeptical about this one. The Resource Saver mode had problems when it was introduced but over several releases most issues seem to have been ironed out. I am running with Resource Saver mode on and with default time-to-enter (which is 5 minutes) all the time (because that is what most users will have) and do not remember having any issues related to Resource Saver in the last 3 months, say.
There was a problem hiding this comment.
Agree. Lets remove it.
| **Priority:** Low | ||
| **Source:** [Discussion #1671](https://github.com/dotnet/aspire/discussions/1671) | ||
|
|
||
| DCP creates temp files for stdout/stderr capture. Permission or path issues cause "run session could not be started" errors. |
There was a problem hiding this comment.
The referenced issue is very old, related to IDE execution, the error has nothing to do with path permissions. AI fail on this one.
|
|
||
| **Check logic:** | ||
| - On Linux, check if docker is installed via snap (`/snap/bin/docker` symlinks to `/usr/bin/snap`) | ||
| - Warn that `ASPIRE_CONTAINER_RUNTIME=docker` may be needed |
There was a problem hiding this comment.
This env var won't change anything. AI fail.
| **Fix suggestion:** | ||
| ``` | ||
| Set environment variable: ASPIRE_CONTAINER_RUNTIME=docker | ||
| Or install Docker via apt/dnf instead of snap |
| Containers may be accessible on `127.0.0.1` but not `localhost` if IPv6 is misconfigured or hosts file has issues. | ||
|
|
||
| **Check logic:** | ||
| - Verify `localhost` resolves correctly |
There was a problem hiding this comment.
We need to define what this means
|
|
||
| **Fix suggestion:** | ||
| ``` | ||
| Use a symbolic link instead of mounting Dev Drive as a folder |
There was a problem hiding this comment.
It is fine to mount the dev drive as a folder, just use directory symbolic link, not directory junction, for that
| **Check logic:** | ||
| - Detect known corporate security software processes | ||
| - Warn about potential DNS/networking interference if Aspire fails to start | ||
| - Suggest checking with IT if issues persist |
| **Check logic:** | ||
| - Time `docker container ls -n 1` command | ||
| - If slow (>5 seconds), warn about Docker Desktop performance issues | ||
| - Suggest downgrading Docker Desktop or restarting |
There was a problem hiding this comment.
Restarting yes, but downgrading won't help. Also one can set the container runtime type explicitly via env var.
There was a problem hiding this comment.
Yea we should remove this one. I think our docker check is good enough.
| --- | ||
|
|
||
| ### 1.15 Conflicting Environment Variables | ||
| **Priority:** High |
There was a problem hiding this comment.
AI man 😄 . We can probably leave this one out.
Some ideas for doctor checks based on github issues
cc @danegsta @karolz-ms