Fix native to IL line number mappings in SOS test scripts#5740
Open
leculver wants to merge 1 commit intodotnet:mainfrom
Open
Fix native to IL line number mappings in SOS test scripts#5740leculver wants to merge 1 commit intodotnet:mainfrom
leculver wants to merge 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes alternative line number matches from SOS test scripts that were required to support older runtime versions. After a runtime fix for native-to-IL line number mappings landed, tests can now expect exact line numbers instead of patterns like (11|20) or (53|57).
Changes:
- Removed alternative line number patterns from six SOS test script files
- Updated expectations to use single, correct line numbers that match actual source code locations
- Aligned with the IL conversion fix referenced in issue #794
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| TaskNestedException.script | Updated line numbers for RandomUserTask constructor (19→26) and InnerException (37→38) |
| StackTests.script | Updated NestedExceptionTest.Program.Main line number from (11|20) to 20 |
| StackAndOtherTests.script | Updated line numbers for Foo2 (31→32) and Foo4 (53→57) across multiple ClrStack commands |
| OtherCommands.script | Updated line numbers for Foo2 (31→32) and Foo4 (37|57→37) |
| NestedExceptionTest.script | Updated NestedExceptionTest.Program.Main line number from (11|20) to 20 |
| DivZero.script | Updated DivZero C.Main line number from (57|56) to 57 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Taking a look at the failures tomorrow. |
noahfalk
previously approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove alternative line number matches (e.g., (53|57), (11|20)) that were needed for older runtime versions. Now that the IL conversion fix has landed, tests should expect the correct line numbers only.
Fixes #794