Handle 404 in GetAllImageDigestsFromRegistryAsync#2055
Merged
lbussell merged 3 commits intodotnet:mainfrom Mar 31, 2026
Merged
Conversation
…meration When enumerating manifests from the registry, a manifest can be deleted between the time it is listed by GetAllManifestPropertiesAsync and when GetManifestAsync attempts to fetch it. This race condition occurs when the registry has retention policies or concurrent cleanup operations. Catch RequestFailedException with status 404 and skip the manifest instead of crashing the entire command. This was the root cause of the cleanup pipeline (cleanup-acr-images-official) failing consistently. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
NikolaMilosavljevic
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When enumerating manifests from the registry, a manifest can be deleted between the time it is listed by
GetAllManifestPropertiesAsyncand whenGetManifestAsyncattempts to fetch it.This race condition can occur when the registry has retention policies that delete images or if there is a concurrent cleanup operation happening.
This PR catches RequestFailedException with status 404 and skips the missing manifest instead of crashing the entire command.