-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Address feedback from peer review #50567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| The .NET SDK displays text similar to the following when you first run one of the [.NET CLI commands](index.md) (for example, `dotnet build`). Text might vary slightly depending on the version of the SDK you're running. This "first run" experience is how Microsoft notifies you about data collection. | ||
|
|
||
| > [!NOTE] | ||
| > **Breaking change:** The behavior of telemetry messages written to `stderr` has changed in recent versions of the .NET SDK. For more information, see [dotnet CLI commands log non-command-relevant data to stderr](../compatibility/sdk/10.0/dotnet-cli-stderr-output.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it's good to remove this considering this is new behavior introduced in .NET 10?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved this note down 10 lines. The recommendation was to move the note so that the output isn't separated from its intro text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request addresses peer review feedback for the .NET SDK telemetry documentation by improving organization, clarity, and privacy guidance. The changes reorganize telemetry data collection information into a more scannable tabbed format by SDK version, enhance privacy disclosures, and improve formatting consistency throughout the document.
Key changes:
- Reorganized telemetry data collection from a table format to version-specific tabs with bulleted lists for better readability
- Enhanced privacy guidance with earlier placement, clearer language, and a link to the Microsoft Privacy Statement
- Improved formatting consistency by using code formatting for environment variable names in tables
Co-authored-by: Copilot <[email protected]>
Summary
This pull request updates the .NET SDK telemetry documentation to improve clarity, privacy guidance, and formatting. The most important changes include a new section on avoiding inadvertent disclosure of sensitive information, a more readable and organized list of collected telemetry data by SDK version, and improved formatting of environment variable and agent tables.
Fixes #49866
Internal previews