Add parameterless overloads for AddPooledDbContextFactory<TContext>#37144
Merged
AndriySvyryd merged 1 commit intodotnet:mainfrom Feb 26, 2026
Merged
Conversation
Contributor
Author
|
@dotnet-policy-service agree |
src/EFCore/Extensions/EntityFrameworkServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
This PR introduces two parameterless overloads for AddPooledDbContextFactory<TContext> to improve ergonomics when using the centralized configuration model via ConfigureDbContext<TContext>. The overloads delegate to the existing implementation with a no-op action, allowing options to flow automatically without redundant configuration lambdas.
- Adds parameterless
AddPooledDbContextFactory<TContext>()overload - Adds
AddPooledDbContextFactory<TContext>(int poolSize)overload with custom pool size - Includes comprehensive test coverage validating integration with
ConfigureDbContext
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/EFCore/Extensions/EntityFrameworkServiceCollectionExtensions.cs | Adds two new public API overloads for pooled factory registration without configuration lambdas, delegating to existing overload with static no-op action |
| test/EFCore.Tests/Infrastructure/AddPooledDbContextFactoryParameterlessTest.cs | New test file with 5 tests covering parameterless factory scenarios: ConfigureDbContext integration, custom pool size, scoped resolution, singleton pool registration, and error handling without configuration |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
src/EFCore/Extensions/EntityFrameworkServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore/Extensions/EntityFrameworkServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore/Extensions/EntityFrameworkServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore/Extensions/EntityFrameworkServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
249ae47 to
6b86657
Compare
…igning pooled factory with ConfigureDbContext<TContext>. Fixes dotnet#34657
db591f6 to
97ff8ad
Compare
AndriySvyryd
approved these changes
Feb 26, 2026
Member
|
Thanks for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces two new overloads (parameterless + poolSize) that delegate to the existing
(IServiceProvider, DbContextOptionsBuilder)overload with a no-op action.Aligns pooled factory ergonomics with the centralized configuration model
ConfigureDbContext<TContext>.Keeps full backward compatibility; no existing signature or behavior changed.
Motivation
When using
ConfigureDbContext<TContext>, callers shouldn’t have to pass an extra configuration lambdato pooled factory registration; options should flow automatically.
Design
static (_, __) => { }.ConfigureDbContextoverload; no behavioral drift.Tests
Added
AddPooledDbContextFactoryParameterlessTestcovering:ConfigureDbContextprovider (InMemory).poolSizeoverload resolves correctly.TContextworks.Compatibility
Issues
Fixes #34658