Enable VS integration tests on CI#19930
Open
abonie wants to merge 27 commits into
Open
Conversation
Contributor
✅ No release notes required |
Can't use `dotnet` due to a conflict with mtp/xunit3
github-actions
Bot
added
⚠️ Affects-Test-Tooling
Contributor
|
🔍 Tooling Safety Check — Affects-Build-Infra, Affects-Restore, Affects-Test-Tooling
|
This reverts commit 2458906.
This reverts commit 28ae1d6.
This reverts commit b3d0b5b.
The two GoToDefinitionTests [IdeFact]s were no-ops: after Shell.ExecuteCommandAsync(GotoDefn) the caret line was sampled immediately, but FSharpNavigation.NavigateToItem schedules the actual caret move asynchronously (via JoinableTaskFactory). The previous fixed Task.Delay then re-anchored the caret before navigation landed, making it bounce between the call site and the definition without ever being detected. Replace the fixed delay with GoToDefinitionWithRetryAsync: wait for the project system, anchor the caret on the call site, invoke GotoDefn, then poll for the caret line to change (letting the async navigation land) before treating the attempt as a no-op and retrying. The caret is only re-anchored at the start of each attempt, never while a navigation may be in flight. Add EditorInProcess.ActivateAsync to keep the editor as the active command context after PlaceCaretAsync's dte.Find shifts VS's active selection (otherwise GotoDefn routes to the wrong target and returns E_FAIL). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CI showed FsiAndFsFilesGoToCorrespondentDefinitions now passes but GoesToDefinition still no-ops (GotoDefn never resolves the symbol after 20 attempts, no command error). The only structural difference is that the passing test builds the solution while GoesToDefinition only edited the buffer via SetTextAsync. Building gives the F# checker the project's full options and on-disk source, so the symbol resolves. Mirror the sibling test by building before navigating. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The previous build step left the Build Output pane as the active text view, so PlaceCaretAsync
searched the build log ('Marker add 1 not found in text: Build started...') instead of the
source. Re-open Library.fs after building to make it the active document again, mirroring
FsiAndFsFilesGoToCorrespondentDefinitions which opens the file it navigates after building.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…igation Root cause is now understood, so the retry loop is unnecessary: * F# resolves the definition synchronously (FSharpNavigation.TryGoToDefinition blocks on the checker via gtdTask.Wait()), so the symbol is found on the first invocation once the project is loaded -- re-issuing the command never helped. GoesToDefinition's no-op was simply a missing build (an un-built project has no checker options), already fixed in the test body. * Only the navigation is asynchronous (NavigateToItem schedules the caret move via JoinableTaskFactory), so we issue GotoDefn once and wait for that single navigation to land. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Removing the retry loop regressed GoesToDefinition on CI (build 1463019): 'GoToDefn did not navigate away from add 1 within 10s'. The first GotoDefn invocation genuinely no-ops -- the Roslyn Document / F# checker is not ready for the freshly rebuilt+reopened file -- and returns without navigating, so waiting longer on that single call cannot help; the command must be RE-ISSUED. Restore the retry loop (which already waits for the async navigation after each invocation) and document why re-issuing is load-bearing so it is not removed again. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replaces the retry loop (which could mask a real GoToDefinition regression by eventually succeeding) with: wait for the project system, wait a fixed FSharpCheckerSettleDelay (10s) for the F# checker to typecheck the just-opened/built document, then issue GotoDefn ONCE and wait for the single async navigation to land. A genuine no-op now fails the test instead of being retried away. FSharpCheckerSettleDelay may need tuning based on CI timing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CI (build 1463623) confirmed the asymmetry: FsiAndFs (adds files to disk, opens them fresh) passes a single GotoDefn, while GoesToDefinition (SetTextAsync on the auto-opened buffer) no-ops on the first invocation even after a 10s settle. Editing an already-open buffer is the difference, not timing. So restructure GoesToDefinition to mirror FsiAndFs: write the code to Test.fs, build, open it fresh, then navigate. With a fresh document a single GotoDefn resolves, so remove both the retry loop and the fixed settle -- the only remaining wait observes the one async navigation landing, and a genuine no-op now fails the test instead of being retried/slept away. Also drop the redundant standalone PlaceCaretAsync calls (GoToDefinitionAsync already places the caret). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP Testing on CI